provider/aws: Fix reading auto scaling group availability zones #5044
Conversation
Fixes a diff calculation error when only a VPC zone identifiers is provided. In this case the associated availability zones are computed from the subnets per the AWS documentation.
|
Hi @tpounds, Thanks for the PR. The only issue with it is the removal of the instances being created as part of the test. That should, ideally, be discussed in another issue :) Paul |
|
@stack72 Thanks for merging with the test instance removal! I noticed this is true of many of the other auto scaling group acceptance tests as well. I'll look into cleaning this up further in another pull request. |
|
Oops! I actually missed that this pull request hasn't been merged yet. I'll split out the acceptance test change in a separate pull request. |
|
Thanks @tpounds - i'll merge when travis goes green :) thanks again! |
provider/aws: Fix reading auto scaling group availability zones
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
A similar issue to pull request #4597 that fixes reading an auto scaling group's associated availability zones when only VPC zone identifiers (e.g. subnets) are specified. The availability zone attribute is now computed since AWS will supply the availability zones corresponding to the VPC zone identifiers.